fix xcode-10.2 issues #891

ottosuess · 2019-03-26T12:01:02Z

resolves #888

In Xcode 10.2 beta 4 the macro #function shows a different behaviour. As SQLite.swift relies on #function in different subroutines for the composition of SQLite queries, several bugs linked to invalid SQLite statements seem to be introduced.

I replaced all the #function magic by static strings.

tanzolone

Good idea getting rid of the #function.
However I would suggest avoiding using multiple duplicated string literals all over the place (as they are harder to refactor and error prone). A form of mapping might be helpful here: e.g.

enum Function: String {
case count
case greaterThan = ">"
...
}

Strings to enum constants

tanzolone

Thanks for fixing this, looks great! I have a couple of small suggestions.

tanzolone · 2019-03-27T10:55:52Z

Sources/SQLite/Typed/CoreFunctions.swift

@@ -24,6 +24,40 @@

 import Foundation

+private enum Functions: String {


enum name should be singular e.g. Function

tanzolone · 2019-03-27T10:59:28Z

Sources/SQLite/Typed/CoreFunctions.swift

+    case trim
+    case replace
+    case substr
+    case LIKE


as a convention case name should be lower case - I'd personally change those (e.g. case like = "LIKE")

Yep. I think the common naming style is better. Updated.

tanzolone · 2019-03-27T11:00:55Z

Sources/SQLite/Typed/Operators.swift

@@ -24,266 +24,297 @@

 // TODO: use `@warn_unused_result` by the time operator functions support it

+private enum Operators: String {


Ditto, better singular Operator

Fixed enums naming

tanzolone · 2019-03-28T08:10:09Z

This look good - could you kindly have a look at the failing CI checks?

ypopovych · 2019-03-28T08:17:54Z

Travis bug. Couldn't start watch simulator

…

On Thu, 28 Mar 2019, 10:10 Antonio Tanzola, ***@***.***> wrote: This look good - could you kindly have a look at the failing CI checks? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#891 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFMkUQ4gF_BeSbOT6QZ4XM0BCCRHFzKks5vbHkDgaJpZM4cLQ94> .

ypopovych · 2019-03-30T11:25:54Z

@stephencelis What do you think? Can you merge it? The library doesn't work in Xcode 10.2 at all :(

sznowicki · 2019-03-30T19:42:16Z

Just wanted to thank you @ypopovych for this work.

stephencelis

Thanks! Sorry for the delay. I'll also added you as a contributor if you'd like to help continue unblock these kinds of things in the future.

eschao · 2019-03-31T10:14:52Z

@here: After updated codes to latest, I still get unrecognized token: ":" error when count table. Is it really solved? Thanks!

nickgzzjr · 2019-04-01T00:01:30Z

@eschao The version in the podspec has not gotten bumped so your CocoaPods is probably caching the pod. You could clear your CocoaPods cache, you could point directly to this git repo, or you could wait until they bump the version. 😄 I had pointed to ottosuess's git repo and all the errors had gone away.

wddwycc · 2019-04-01T03:11:59Z

@stephencelis could you please make a release for this PR ?

eschao · 2019-04-01T08:40:50Z

@nickgzzjr No cocoapods, I use carthage, I deleted all including carthage checkout, carthage build and cache, and then updated again. but the problem is still existing. Any step I missed or made wrong?

mitesh-iosdev · 2019-04-07T12:44:47Z

@stephencelis could you please make a release for this PR ?

Please update ASAP if the issue is fixed.

PatoSalazarNascent · 2019-05-07T15:58:01Z

@stephencelis Did this update got released in a new version of the pod?? I just updated mine to 0.12.0 but I am still having the issue...

tuchangwei · 2019-05-16T07:32:44Z

@eschao The version in the podspec has not gotten bumped so your CocoaPods is probably caching the pod. You could clear your CocoaPods cache, you could point directly to this git repo, or you could wait until they bump the version. 😄 I had pointed to ottosuess's git repo and all the errors had gone away.

I pointed to ottosuess's git repo, but I still get the error:

created_at > date

use asSQL() function to convert to sql

"created_at" >(_:_:) 0.0

ypopovych · 2019-05-23T15:02:21Z

It should work from CocoaPods. 0.12.0

fix xcode-10.2 issues

c96a5da

tanzolone suggested changes Mar 26, 2019

View reviewed changes

ypopovych and others added 2 commits March 26, 2019 17:54

Strings to enum constants

c5be72b

Merge pull request #1 from ypopovych/master

becacc7

Strings to enum constants

tanzolone suggested changes Mar 27, 2019

View reviewed changes

ypopovych and others added 2 commits March 27, 2019 13:48

Fixed enums naming

bc909ad

Merge pull request #2 from ypopovych/master

1a34caf

Fixed enums naming

stephencelis approved these changes Mar 30, 2019

View reviewed changes

stephencelis merged commit 861ff28 into stephencelis:master Mar 30, 2019

timshadel mentioned this pull request Apr 2, 2019

Invalid SQL statements with Xcode 10.2 #888

Closed

		@@ -24,6 +24,40 @@

		import Foundation

		private enum Functions: String {

		@@ -24,266 +24,297 @@

		// TODO: use `@warn_unused_result` by the time operator functions support it

		private enum Operators: String {

Uh oh!

fix xcode-10.2 issues #891

fix xcode-10.2 issues #891

Conversation

ottosuess commented Mar 26, 2019

Uh oh!

tanzolone left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tanzolone left a comment

Choose a reason for hiding this comment

Uh oh!

tanzolone Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

ypopovych Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

tanzolone Mar 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ypopovych Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

tanzolone Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

ypopovych Mar 27, 2019

Choose a reason for hiding this comment

Uh oh!

tanzolone commented Mar 28, 2019

Uh oh!

ypopovych commented Mar 28, 2019 via email

Uh oh!

ypopovych commented Mar 30, 2019

Uh oh!

sznowicki commented Mar 30, 2019

Uh oh!

stephencelis left a comment

Choose a reason for hiding this comment

Uh oh!

eschao commented Mar 31, 2019

Uh oh!

nickgzzjr commented Apr 1, 2019

Uh oh!

wddwycc commented Apr 1, 2019

Uh oh!

eschao commented Apr 1, 2019

Uh oh!

mitesh-iosdev commented Apr 7, 2019

Uh oh!

PatoSalazarNascent commented May 7, 2019

Uh oh!

tuchangwei commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ypopovych commented May 23, 2019

Uh oh!

Uh oh!

tanzolone left a comment •

edited

Loading

tanzolone Mar 27, 2019 •

edited

Loading

tuchangwei commented May 16, 2019 •

edited

Loading